Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

dgpe misses dupes when transparency is involved

#64

After having noticed that some exact duplicates had a less-than-100% match in the Cocoa version, I investigated for a few hours (yeah, it took me quite a while to click on that one) and found that images with transparency were the problem.

After some digging I found out the cause of the problem, which is the malloc() on the BitmapContext creation routine. This pixel buffer initialization doesn't zero out the pixels, and when the image is drawn in the buffer, transparent pixels are not touched, which means that these pixels stay undefined.

It means that two pictures that are exactly the same will most likely have different block when analyzed (which is bad).

Reported by Virgil Dupras · September 28th, 2009 @ 05:23 PM

State: fixed
Assigned to: Virgil Dupras Virgil Dupras

Activity

  1. Virgil Dupras
    Virgil Dupras
    • State changed from new to accepted

    September 28th, 2009 @ 05:23 PM

  2. Virgil Dupras
    Virgil Dupras
    • Assigned user set to Virgil Dupras

    September 28th, 2009 @ 05:24 PM

  3. Virgil Dupras
    Virgil Dupras
    • State changed from accepted to fixed

    (from [150]) [#64 dgpe misses dupes when transparency is involved state:fixed] fixed a bug in PictureBlocks where transparency could make two equal pictures return two different sets of blocks.

    September 28th, 2009 @ 05:33 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.