#140 None items in results causing crashes. - dupeGuru

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#140 ✓fixed

None items in results causing crashes.

Reported by Virgil Dupras | February 2nd, 2011 @ 02:31 PM

I got 3 crash reports caused by None results in a row. Strange.

Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 2.0.0

Traceback (most recent call last):
  File "/Applications/dupeGuru PE.app/Contents/Resources/dg_cocoa.plugin/Contents/Resources/dg_cocoa.py", line 27, in getSelectedDupeRefPath
  File "core_pe/app_cocoa.pyc", line 210, in selected_dupe_ref_path
AttributeError: 'NoneType' object has no attribute 'path'

Application Name: dupeGuru Picture Edition
Version: 1.11.3

Traceback (most recent call last):
  File "/usr/local/share/dupeguru_pe/qt/base/main_window.py", line 321, in detailsTriggered
    self.app.show_details()
  File "/usr/local/share/dupeguru_pe/qt/base/app.py", line 179, in show_details
    self.details_dialog.show()
  File "/usr/local/share/dupeguru_pe/qt/pe/details_dialog.py", line 95, in show
    self._update()
  File "/usr/local/share/dupeguru_pe/qt/pe/details_dialog.py", line 72, in _update
    self.referencePixmap = QPixmap(str(ref.path))
AttributeError: 'NoneType' object has no attribute 'path'

Application Name: dupeGuru Picture Edition
Version: 2.0.0

Traceback (most recent call last):
File qt\base\result_window.py, line 263, in detailsTriggered File qt\base\app.py, line 203, in show_details File qt\pe\details_dialog.py, line 96, in show File qt\pe\details_dialog.py, line 73, in _updateAttributeError: 'NoneType' object has no attribute 'path'

Comments and changes to this ticket

Virgil Dupras February 16th, 2011 @ 11:39 AM
- Tag changed from “bug” to “bug, pe”
I got two new ones from dgpe (cocoa version) 2.0.0

It seems to be specific to PE.
Virgil Dupras February 17th, 2011 @ 06:08 PM
More details from a user (who had the same crash, pe_cocoa 2.0.0):

I had scanned, and then selected "Dupes Only". I then moved the dupes to a new location using the dropdown menu. The error occurred when I tried to switch back to "Details". The app kept running in spite of the error. The scan was of files on a USB drive attached to my AirPort Extreme Base Station, if that matters.
Virgil Dupras February 18th, 2011 @ 09:44 AM
- Assigned user set to “Virgil Dupras”
Virgil Dupras February 18th, 2011 @ 10:37 AM
- State changed from “new” to “fixed”
(from [245fcaf252fc]) [#140 state:fixed] Fixed a crash on showing details panel in PE right after a mark-based removal (selection wasn't refreshed). https://bitbucket.org/hsoft/dupeguru/changeset/245fcaf252fc/
Virgil Dupras March 7th, 2011 @ 11:23 AM
- Tag changed from “bug, pe” to “bug”
For the record, this error is not specific to PE. It also happens if you use Make Selected Reference right after an action that removes marked dupes.

Virgil Dupras April 1st, 2011 @ 06:56 PM

State changed from “fixed” to “accepted”

Well, gotta re-open the ticket because I got a couple of more crash report for pe2.1.0. A lot of them seem to be related to dupe renaming.

Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 2.1.0

Traceback (most recent call last):
 File "core/app_cocoa_inter.pyc", line 202, in renameSelected_
 File "core/gui/result_table.pyc", line 105, in rename_selected
AttributeError: 'NoneType' object has no attribute '_data'

Application Identifier: com.hardcoded_software.dupeguru_pe
Application Version: 2.1.0

Traceback (most recent call last):
 File "core/app_cocoa_inter.pyc", line 156, in jobCompleted_
 File "core/app.pyc", line 116, in _job_completed
 File "core/app.pyc", line 109, in _results_changed
 File "hscommon/notify.pyc", line 19, in notify
 File "hscommon/notify.pyc", line 52, in dispatch
 File "core/gui/result_table.pyc", line 151, in results_changed
 File "core/gui/result_table.pyc", line 89, in _refresh_with_view
 File "hscommon/gui/table.pyc", line 257, in refresh
 File "hscommon/cocoa/inter.pyc", line 55, in refresh
 File "core/app_cocoa_inter.pyc", line 202, in renameSelected_
 File "core/gui/result_table.pyc", line 105, in rename_selected
AttributeError: 'NoneType' object has no attribute '_data'

The two above seem to be related. From two different users, I got these two reports, one after the other (within a minute of each other)

Application Identifier: com.hardcoded_software.dupeguru_pe
Application
Version: 2.1.0

Traceback (most recent call last):
 File "hscommon/cocoa/__init__.pyc", line 53, in _async_run
 File "core_pe/app_cocoa.pyc", line 162, in _do_delete
 File "core/results.pyc", line 244, in perform_on_marked
 File "core_pe/app_cocoa.pyc", line 150, in op
 File "core_pe/app_cocoa.pyc", line 168, in _do_delete_dupe
AttributeError: 'NoneType' object has no attribute 'photos'

oh, and also me6.0.1

Application Name: dupeGuru Music Edition
Version: 6.0.1

Traceback (most recent call last):
 File "/usr/local/share/dupeguru_me/qt/base/results_model.py", line 80, in setData
   return self.model.rename_selected(value)
 File "/usr/local/share/dupeguru_me/core/gui/result_table.py", line 105, in rename_selected
   row._data = None
AttributeError: 'NoneType' object has no attribute '_data'

Virgil Dupras April 13th, 2011 @ 04:10 PM
I could reproduce the error by initiating a rename and then, while the edit box is visible, remove the selected row from results.
Virgil Dupras April 13th, 2011 @ 04:16 PM
Also: the report on PE 2.1.0 that has nothing to do with renaming is somewhat of a mystery, but since I only received one of these reports, I'll let it slide and ask for more details in the next report.
Virgil Dupras April 13th, 2011 @ 04:23 PM
- State changed from “accepted” to “fixed”
(from [ceb5ae1bdfc3]) [#140 state:fixed] Fixed a crash on dupe renaming. https://bitbucket.org/hsoft/dupeguru/changeset/ceb5ae1bdfc3/

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Shared Ticket Bins (Sort)

↓↑ drag 42 Open tickets
↓↑ drag 159 Fixed tickets
↓↑ drag 8 Open Bugs
↓↑ drag 8 Needs Review
↓↑ drag 8 Accepted Tickets
↓↑ drag 26 On Hold

People watching this ticket

Virgil Dupras

Referenced by

140 None items in results causing crashes. (from [ceb5ae1bdfc3]) [#140 state:fixed] Fixed a crash on...
140 None items in results causing crashes. (from [245fcaf252fc]) [#140 state:fixed] Fixed a crash on...

Hardcoded dupeGuru

None items in results causing crashes.

Comments and changes to this ticket

Virgil Dupras February 16th, 2011 @ 11:39 AM

Virgil Dupras February 17th, 2011 @ 06:08 PM

Virgil Dupras February 18th, 2011 @ 09:44 AM

Virgil Dupras February 18th, 2011 @ 10:37 AM

Virgil Dupras March 7th, 2011 @ 11:23 AM

Virgil Dupras April 1st, 2011 @ 06:56 PM

Virgil Dupras April 13th, 2011 @ 04:10 PM

Virgil Dupras April 13th, 2011 @ 04:16 PM

Virgil Dupras April 13th, 2011 @ 04:23 PM

Create your profile

Shared Ticket Bins (Sort)

People watching this ticket

Tags

Referenced by

Pages

Keyword searching

None items in results causing crashes.

Comments and changes to this ticket

Create your profile

Shared Ticket Bins (Sort)

People watching this ticket

Tags

Referenced by

Pages