Detect / configure 'default' date format for importing
-
Virgil Dupras
- State changed from new to accepted
- Tag changed from import to feature, import
That's a good idea. I don't know about date format selection upon ambiguity (it might be a lot of effort for what it's worth), but simply prioritizing the local date format would go a long way. It wouldn't work for all cases, but it would be better than the current hardcoded date format priority.
-
Virgil Dupras
I just thought of something. The current date swapping scheme isn't optimal because it might be hard to be aware that there was an ambiguity during date parsing. It's easy to let a day/month mess up go unnoticed.
What if instead of the current swap choices, there was a combobox with all possible date format choices. Most of the time, this combobox would have only one item (because ambiguities are rather rare), but when there's the possibility of an ambiguity, it will be much easier to spot.
Selecting an item in that combobox wouldn't really trigger a re-parsing (it's not needed) but simply do date swapping like it does now, but to the user, it would look like a new date format is being reapplied to the dates.
-
frog
That sounds like a much better interface than the date swapping — I'm very likely to know the date format in the file, and also more likely to spot the mis-parsing if the detected format is displayed directly.
(And I guess this might make it easier to default to using the system localisation settings...?)
-
Virgil Dupras
- Assigned user set to Virgil Dupras
-
Virgil Dupras
(from [e60bd1d41fb5]) [#325 Detect / configure 'default' date format for importing] Pushed the swap type selector's content and logic down to the core. https://bitbucket.org/hsoft/moneyguru/changeset/e60bd1d41fb5/
-
Virgil Dupras
(from [b457ed906833]) [#325 Detect / configure 'default' date format for importing] pytest-ified import_window_test. https://bitbucket.org/hsoft/moneyguru/changeset/b457ed906833/
-
Virgil Dupras
- State changed from accepted to fixed
(from [741ce24a19ad]) [#325 Detect / configure 'default' date format for importing state:fixed] Changed the label of the 3 date swap items in the import window.
Instead of just telling which fields they swap, they display the current and if-fixed date formats, thus improving the clarity of the operation. Moreover, the default date format of the system is tried first (unless the parsed format has a native date format) before trying the whole list of date formats.
That was a lot of work for a seemingly simple feature...
https://bitbucket.org/hsoft/moneyguru/changeset/741ce24a19ad/
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.