No Ability to Merge Accounts
-
Randy Becker
Looking at the other tickets, I guess this is similar to #24 Copy and paste support, and contemplated in #11 Easily cycle through the transaction entries.
-
Virgil Dupras
- Tag changed from import, quicken to import, quicken, suggestion
There's a relatively new feature where if you delete an account that isn't empty, you will be prompted for another account to assign the transactions to.
Yeah, I guess that drag & dropping an account on another one to merge them should be allowed...
-
Randy Becker
Ah, I didn't think to try deleting the account. I suppose that makes some sense, since double-entry abhors the creation of money.
This does raise another issue, however. The list of accounts presented is not sorted. At least, not in any way I can comprehend.
-
Virgil Dupras
Yeah no, there's no sorting taking place in gui/account_reassign_panel.py. The reason why I didn't bother is probably because this kind of operation is so seldom made. A quick change to
accounts = self.document.accounts[:].sort(key=lambda a: a.name)on line 15 is a quick fix to make your batch merging easier for now, as a workaround until the issue is fixed. -
Randy Becker
Hmm... I made the change, but then I get two errors when I try to delete an account:
Traceback (most recent call last):
File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 1045, in loadPanel File "moneyguru/gui/account_reassign_panel.pyc", line 16, in loadAttributeError: 'NoneType' object has no attribute 'remove'
and
Traceback (most recent call last):
File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 537, in deleteSelected File "moneyguru/gui/report.pyc", line 126, in delete File "moneyguru/document/__init__.pyc", line 371, in delete_selected_account File "hsutil/notify.pyc", line 18, in notify File "hsutil/notify.pyc", line 36, in dispatch File "moneyguru/gui/main_window.pyc", line 74, in account_needs_reassignment File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 1110, in show_account_reassign_panel File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 1045, in loadPanel File "moneyguru/gui/account_reassign_panel.pyc", line 16, in loadAttributeError: 'NoneType' object has no attribute 'remove'
-
Virgil Dupras
Oh, yeah, I'm stupid,
sort()returnsNone. The correct line would beaccounts = sorted(self.document.accounts[:], key=lambda a: a.name) -
Virgil Dupras
(and you don't even need the
[:], sorted copies the iterable) -
Randy Becker
That did it. Thanks!
-
Virgil Dupras
- Tag changed from import, quicken, suggestion to feature, import, quicken
[not-tagged:"suggestion" tagged:"feature" bulk edit command]
-
Virgil Dupras
- State changed from new to hold
I'm not convinced by a need for this feature. The problem is that the most obvious way to merge accounts would be for it to be triggered by drag&dropping an account onto another. However, drag & drop is already used for group/type changes. I fear that adding this new drag & drop behavior would cause more trouble than the convenience it adds.
Putting this on hold.
-
Randy Becker
I think this feature is already implemented via the delete behavior. Especially when #55 Ability to Select Multiple Accounts Simultaneously is implemented, there's no need for additional UI. I agree that drag & drop would an obvious choice, but it would be confusing, as it would be different (and more destructive) behavior than how drag & drop is already used.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.