#51 hold
Randy Becker

No Ability to Merge Accounts

Reported by Randy Becker | 2009-08-16 17:29:22 UTC

In Quicken, I used classes. I have since decided that the way I used them was not actually helpful. I only had three classes, and most expenses fell into one of them. In Quicken, I can ignore the existence of the classes, as most reports operate on the category level. When I imported my data into moneyGuru, however, the number of expense accounts is about three times greater than it should be, as most expenses have a duplicate expense account followed by /className. I wanted to merge the duplicates together, but couldn't find a way to easily to so.

I can't select multiple accounts in the Profit/Loss view, and renaming one account to the name of another throws an error, and prevents the rename. I also tried cutting the transactions from one account to paste them into another account, but cutting transactions doesn't work.

Comments and changes to this ticket

  • Randy Becker

    Randy Becker 2009-08-16 17:50:02 UTC

    Looking at the other tickets, I guess this is similar to #24, and contemplated in #11.

  • Virgil Dupras

    Virgil Dupras 2009-08-16 17:52:15 UTC

    • Tag changed from “import, quicken” to “import, quicken, suggestion”

    There's a relatively new feature where if you delete an account that isn't empty, you will be prompted for another account to assign the transactions to.

    Yeah, I guess that drag & dropping an account on another one to merge them should be allowed...

  • Randy Becker

    Randy Becker 2009-08-16 18:05:24 UTC

    Ah, I didn't think to try deleting the account. I suppose that makes some sense, since double-entry abhors the creation of money.

    This does raise another issue, however. The list of accounts presented is not sorted. At least, not in any way I can comprehend.

  • Virgil Dupras

    Virgil Dupras 2009-08-16 18:18:58 UTC

    Yeah no, there's no sorting taking place in gui/account_reassign_panel.py. The reason why I didn't bother is probably because this kind of operation is so seldom made. A quick change to accounts = self.document.accounts[:].sort(key=lambda a: a.name) on line 15 is a quick fix to make your batch merging easier for now, as a workaround until the issue is fixed.

  • Randy Becker

    Randy Becker 2009-08-16 20:41:56 UTC

    Hmm... I made the change, but then I get two errors when I try to delete an account:

    Traceback (most recent call last):

    File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 1045, in loadPanel
    File "moneyguru/gui/account_reassign_panel.pyc", line 16, in load
    

    AttributeError: 'NoneType' object has no attribute 'remove'

    and

    Traceback (most recent call last):

    File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 537, in deleteSelected
    File "moneyguru/gui/report.pyc", line 126, in delete
    File "moneyguru/document/__init__.pyc", line 371, in delete_selected_account
    File "hsutil/notify.pyc", line 18, in notify
    File "hsutil/notify.pyc", line 36, in dispatch
    File "moneyguru/gui/main_window.pyc", line 74, in account_needs_reassignment
    File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 1110, in show_account_reassign_panel
    File "/Users/rbecker1/Desktop/moneyguru/cocoa/build/Release/moneyGuru.app/Contents/Resources/mg_cocoa.plugin/Contents/Resources/mg_cocoa.py", line 1045, in loadPanel
    File "moneyguru/gui/account_reassign_panel.pyc", line 16, in load
    

    AttributeError: 'NoneType' object has no attribute 'remove'

  • Virgil Dupras

    Virgil Dupras 2009-08-16 20:45:35 UTC

    Oh, yeah, I'm stupid, sort() returns None. The correct line would be accounts = sorted(self.document.accounts[:], key=lambda a: a.name)

  • Virgil Dupras

    Virgil Dupras 2009-08-16 20:47:50 UTC

    (and you don't even need the [:], sorted copies the iterable)

  • Randy Becker

    Randy Becker 2009-08-16 20:55:39 UTC

    That did it. Thanks!

  • Virgil Dupras

    Virgil Dupras 2009-09-05 19:10:32 UTC

    • Tag changed from “import, quicken, suggestion” to “feature, import, quicken”

    [not-tagged:"suggestion" tagged:"feature" bulk edit command]

  • Virgil Dupras

    Virgil Dupras 2010-04-30 09:01:16 UTC

    • State changed from “new” to “hold”

    I'm not convinced by a need for this feature. The problem is that the most obvious way to merge accounts would be for it to be triggered by drag&dropping an account onto another. However, drag & drop is already used for group/type changes. I fear that adding this new drag & drop behavior would cause more trouble than the convenience it adds.

    Putting this on hold.

  • Randy Becker

    Randy Becker 2010-05-18 06:37:18 UTC

    I think this feature is already implemented via the delete behavior. Especially when #55 is implemented, there's no need for additional UI. I agree that drag & drop would an obvious choice, but it would be confusing, as it would be different (and more destructive) behavior than how drag & drop is already used.

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป

Shared Ticket Bins

People watching this ticket

Referenced by

Pages